feat: remove deprecated has_downloads and ignore_vulnerability_alerts_during_read variables#20
Merged
Igor Rodionov (goruha) merged 7 commits intomainfrom Apr 14, 2026
Merged
Conversation
…erts_during_read variables has_downloads was deprecated by GitHub and previously marked deprecated in this module. ignore_vulnerability_alerts_during_read is a no-op as the provider now handles lack of permissions automatically. Both variables and all references removed from module root, examples, README, and fixtures.
Copilot started reviewing on behalf of
John C. Bland II (johncblandii)
April 9, 2026 21:14
View session
John C. Bland II (johncblandii)
changed the title
There was a problem hiding this comment.
Pull request overview
This PR removes two deprecated/no-op module inputs (has_downloads and ignore_vulnerability_alerts_during_read) and cleans up their usage across the root module, examples, and documentation to match current GitHub/provider behavior.
Changes:
- Removed
has_downloadsvariable and its deprecation enforcement check. - Removed
ignore_vulnerability_alerts_during_readvariable and itsgithub_repositoryresource attribute wiring. - Updated README/README.yaml and example configurations/fixtures to eliminate references to the removed inputs.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| variables.tf | Drops the two inputs from the module interface. |
| main.tf | Removes the repository resource attribute and the has_downloads deprecation check block. |
| README.md | Removes the inputs from usage snippet and generated inputs table. |
| README.yaml | Removes has_downloads from the usage example snippet. |
| examples/minimum/variables.tf | Removes ignore_vulnerability_alerts_during_read example variable. |
| examples/minimum/main.tf | Removes passing ignore_vulnerability_alerts_during_read into the module. |
| examples/complete/variables.tf | Removes ignore_vulnerability_alerts_during_read example variable. |
| examples/complete/main.tf | Removes passing ignore_vulnerability_alerts_during_read into the module. |
| examples/complete/fixtures.us-east-2.tfvars | Removes the fixture value for ignore_vulnerability_alerts_during_read. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
/terratest |
Igor Rodionov (goruha)
added
major
Member
|
/terratest |
Igor Rodionov (goruha)
approved these changes
Apr 14, 2026
|
These changes were released in v1.4.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
has_downloadsvariable and its deprecation check blockignore_vulnerability_alerts_during_readvariable and its resource attributewhy
has_downloadswas deprecated by GitHub — the feature no longer exists. It was previously marked deprecated in this module via deprecate: mark has_downloads variable as deprecated #17 and is now fully removed.ignore_vulnerability_alerts_during_readis a no-op — the GitHub provider now handles lack of permissions automatically, making this attribute unnecessary.references
has_downloads)